Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails Edge ruby 3.1 #2405

Merged
merged 7 commits into from
Jan 6, 2024
Merged

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Jan 4, 2024

Fix #2404 #2403

@grape-bot
Copy link

grape-bot commented Jan 4, 2024

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

Replace last_response.headers[Rack::CONTENT_TYPE] by last_response.content_type
Replace last_response.headers['Location'] by last_response.content_type
Replace last_response.headers[Rack::CONTENT_LENGTH] by last_response.content_type
@ericproulx ericproulx marked this pull request as ready for review January 5, 2024 21:37
@ericproulx
Copy link
Contributor Author

Edge is 🟢

@ericproulx ericproulx requested a review from dblock January 5, 2024 21:38
@dblock
Copy link
Member

dblock commented Jan 5, 2024

What is the story with rack_3_0 and ChunkedResponse?

@ericproulx
Copy link
Contributor Author

It will be removed starting at 3.1

@dblock
Copy link
Member

dblock commented Jan 6, 2024

Got it, rebase?

@dblock dblock merged commit 6888ad6 into ruby-grape:master Jan 6, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix specs for Rack Edge
3 participants