Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose default in the description dsl. #2324

Merged
merged 1 commit into from
May 9, 2023
Merged

expose default in the description dsl. #2324

merged 1 commit into from
May 9, 2023

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented May 8, 2023

grape-swagger 1.6.0 exposes the ability to define the default response but the description dsl does not support it yet.

This PR adds support to define the default response using the description dsl.

@dblock
Copy link
Member

dblock commented May 8, 2023

Looks good. Needs a README update, please.

@dhruvCW
Copy link
Contributor Author

dhruvCW commented May 9, 2023

Looks good. Needs a README update, please.

added it to the documentation dsl section. IMO the rest of it should be covered by grape-swagger's Readme section.

@dblock dblock merged commit c956e6b into ruby-grape:master May 9, 2023
@dhruvCW dhruvCW deleted the expose-default-in-desc branch May 9, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants