Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rubocop offenses #2296

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Fix Rubocop offenses #2296

merged 3 commits into from
Dec 27, 2022

Commits on Dec 23, 2022

  1. Rerun rubocop --auto-gen-config with --auto-gen-only-exclude --exclud… 

    …e-limit 5000

Move metrics cops in rubocop
Fix Performance/CollectionLiteralInLoop
Fix Performance/MethodObjectAsBlock
Fix RSpec/ClassCheck
Fix RSpec/EmptyExampleGroup
Fix RSpec/IdenticalEqualityAssertion
Fix RSpec/IteratedExpectation
Fix RSpec/LetSetup
Fix Style/MagicCommentFormat
Fix Style/MapToHash
Fix Style/SafeNavigation
Fix Style/SlicingWithRange
Enabled Lint/ConstantDefinitionInBlock
Enabled Lint/EmptyBlock
Enabled RSpec/ContextWording
Enabled RSpec/FilePath
Enabled RSpec/LeakyConstantDeclaration
Enabled RSpec/NamedSubject
    @ericproulx
    ericproulx committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    468d2ca View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG.md

    @ericproulx
    ericproulx committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    51f7685 View commit details
    Browse the repository at this point in the history

  3. Add # rubocop:disable RSpec/IteratedExpectation because Rack::Respons… 

    …e does not respond to :each_with_index
    @ericproulx
    ericproulx committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    76d5eae View commit details
    Browse the repository at this point in the history