-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop to 1.41.0 #2288
Update rubocop to 1.41.0 #2288
Conversation
Danger credentials doesn't work : 401 - Bad credentials |
The account that owned those got reset by GitHub last week :( I'd like to replace this with something like https://github.com/dangoslen/changelog-enforcer to avoid this happening in the future, want to help? |
#2291 rebase? |
5c3ca4c
to
ca04e89
Compare
@dblock did the rebase and put 1.41 since a version came out since I've created the PR |
Looks like some CI is failing on older rubies, probably unrelated but I'd rather not merge, care to take a look? |
|
Looks like we're dropping support for Ruby 2.5 here? Ruby 2.5 is EOL already, so that's ok. Make the necessary changes as needed (change 2.5 to 2.6 or newer as appropriate), get CI to green, and note in CHANGELOG something like "Dropped support for Ruby 2.5". |
Rubocop drop support for ruby 2.5 in April. |
Generated by 🚫 Danger |
Updating rubocop to latest version which is 1.41.0