Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop to 1.41.0 #2288

Merged
merged 13 commits into from
Dec 22, 2022
Merged

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Dec 11, 2022

Updating rubocop to latest version which is 1.41.0

@ericproulx
Copy link
Contributor Author

Danger credentials doesn't work : 401 - Bad credentials

@dblock
Copy link
Member

dblock commented Dec 12, 2022

Danger credentials doesn't work : 401 - Bad credentials

The account that owned those got reset by GitHub last week :( I'd like to replace this with something like https://github.com/dangoslen/changelog-enforcer to avoid this happening in the future, want to help?

@dblock
Copy link
Member

dblock commented Dec 20, 2022

#2291 rebase?

@ericproulx ericproulx changed the title Update rubocop to 1.40.0 Update rubocop to 1.41.0 Dec 20, 2022
@ericproulx
Copy link
Contributor Author

@dblock did the rebase and put 1.41 since a version came out since I've created the PR

@dblock
Copy link
Member

dblock commented Dec 20, 2022

Looks like some CI is failing on older rubies, probably unrelated but I'd rather not merge, care to take a look?

@ericproulx
Copy link
Contributor Author

Bundler found conflicting requirements for the Ruby version:
    In rack1.gemfile:
      rubocop (= 1.41.0) was resolved to 1.41.0, which depends on
        Ruby (>= 2.6.0)
  
    Current Ruby version:
      Ruby (= 2.5.9)

@dblock
Copy link
Member

dblock commented Dec 21, 2022

Looks like we're dropping support for Ruby 2.5 here? Ruby 2.5 is EOL already, so that's ok. Make the necessary changes as needed (change 2.5 to 2.6 or newer as appropriate), get CI to green, and note in CHANGELOG something like "Dropped support for Ruby 2.5".

@ericproulx
Copy link
Contributor Author

Looks like we're dropping support for Ruby 2.5 here? Ruby 2.5 is EOL already, so that's ok. Make the necessary changes as needed (change 2.5 to 2.6 or newer as appropriate), get CI to green, and note in CHANGELOG something like "Dropped support for Ruby 2.5".

Rubocop drop support for ruby 2.5 in April.

@grape-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@dblock dblock merged commit 5e8cd2a into ruby-grape:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants