fix evaluate given in array

[zysend]

evaluate_given ignores tests for arrays, and it judges with the wrong parameters.

[zysend]

application/x-www-form-urlencoded can not handle the ordering of the object elements of the array in params
[{ b: 'b' }, { a: 'a', b: 'b' }] => [{ a: 'a', b: 'b' }, { b: 'b' }]

[dblock]

This looks good! Any reason not to mark this as ready?

[zysend]

I think this row in meets_dependency? may affect the judgment when I use meets_dependency? to judge given

return false if @parent.present? && !@parent.meets_dependency?(@parent.params(request_params), request_params)

spec maybe like:

optional :array, type: Array do
  optional :a
  optional :c
  given :a do
    given :c do
      optional :b
    end
  end
end

[zysend]

Then I added and run

it 'evaluate_given_true' do
  post '/evaluate_given_true', { array: [{ a: 'a', b: 'b' }, { c: 'c', b: 'b'}, { a: 'a', c: 'c', b: 'b' }] }.to_json, 'CONTENT_TYPE' => 'application/json'
  expect(JSON.parse(last_response.body)).to eq('array' => [{ 'a' => 'a', 'c' => nil }, { 'a' => nil, 'c' => 'c' }, { 'a' => 'a', 'b' => 'b', 'c' => 'c' }])
end

got this:

expected: {"array"=>[{"a"=>"a", "c"=>nil}, {"a"=>nil, "c"=>"c"}, {"a"=>"a", "b"=>"b", "c"=>"c"}]}
got: {"array"=>[{"a"=>"a", "c"=>nil}, {"a"=>nil, "b"=>"b", "c"=>"c"}, {"a"=>"a", "b"=>"b", "c"=>"c"}]}

So I have to change the meets_dependency? or create a new method.

[zysend]

I will complete the modification as soon

[dblock]

This LGTM, should I merge this or do you want to do more work on this?

[zysend]

Thanks for the review.There is nothing to change and can be merged.