Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception super #2276

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Fix exception super #2276

merged 5 commits into from
Aug 11, 2022

Conversation

ericproulx
Copy link
Contributor

Fix #2273

@dblock dblock merged commit edc6abe into ruby-grape:master Aug 11, 2022
@ericproulx ericproulx mentioned this pull request Dec 15, 2022
Closed
kuraga
kuraga reviewed Dec 25, 2022
View reviewed changes
lib/grape/exceptions/base.rb
@headers = headers
super(message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be two lines above :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter? If you think it does, PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuraga kuraga kuraga left review comments

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grape:Exceptions::Base missing super?
3 participants
@ericproulx @dblock @kuraga