Add validators module to all validators #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Boolean to Api Class Add test_prof for let_it_be Refactor validators spec without LeakyConstantDeclaration https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LeakyConstantDeclaration
|
Good stuff. +1 on rubocop-rspec, please |
|
hmm, it's a breaking change for custom validators so |
jrmhaig
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Jan 12, 2022
ruby-grape/grape#2200 moves Grape::Validations::Base to Grape::Validations::Validators::Base and this is included in the 1.6.1 release of the grape gem.
dm1try
added a commit
to dm1try/grape
that referenced
this pull request
Feb 17, 2022
Lessons learned here, we should have made a major version bump or built backwards compat, see #2244 |
dm1try
added a commit
to dm1try/grape
that referenced
this pull request
Feb 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While looking at the "validations/validators" folder, I found that 'validators" is not a declared module and I was wondering why. I looked at the "validations/types" and "types" is a declared module. Anyway, I thought that for consistency, it had to be done.
There were also a lot of LeakyConstantDeclaration inside validators specs. I figured it would be better to use AnonymousClasses instead. Unfortunately, declaring an anonymous Grape::API for every single test was slowing down everything and I thought using
let_it_befrom test-prof would be ideal.I think rubocop-rspec could be a great addition for the spec. I could open a PR if you want.