[WIP] Fix same custom route_setting value ignoreing problem #2174
Conversation
Here's an example of a CHANGELOG.md entry: * [#2174](https://github.com/ruby-grape/grape/pull/2174): [wip] fix same custom route_setting value ignoreing problem - [@neocoin](https://github.com/neocoin).Generated by 🚫 Danger |
|
Correct rubocop with |
|
Next step is to bisect down to the commit that broke it, then we can narrow down a fix. |
|
Oh I didn't read convention rules. |
There are no convention rules! I'm just slowly nudging you to find the issue and write a fix :) |
Rollback this commit about Grape::API Fix retaining setup blocks when remounting APIs 416a7e1 416a7e1#diff-74e08e6432db25a22b629a2f8031d24d01f8c9435bda532d36e22971d0b1c9a0R33
| @@ -30,7 +30,7 @@ def inherited(api, base_instance_parent = Grape::API::Instance) | |||
| # an instance that will be used to create the set up but will not be mounted | |||
| def initial_setup(base_instance_parent) | |||
| @instances = [] | |||
| @setup = Set.new | |||
neocoin
changed the title
|
Because #2102 actually did address a memory leak I think we need to find another solution :( |
neocoin
changed the title
|
@dblock hm.. bad situation. I try to apply some solutions but I failed. Basically, '@setup = Set.new' break stackable setting concept of grape I can't find solution that classify always stackable DSL( desc, route_setings, get by code context ) and non-stackable DSL (logger with nil arguments, top_level_setting etc) at runtime after declarative initilization. on https://github.com/ruby-grape/grape/blob/master/lib/grape/api.rb#L42 Do you have any idea? |
|
You probably undertstand more than me now ;) Maybe we can split setup that needs to be retained and setup that doesn't? Anyone else has any ideas? |
|
Too old. Sorry I changed interface to GraphQL. I don't maintain this branch |
#2173 After 1.5.0 , 'route_setting :custom , key: :value' is broken with 'mount'.
check plz. @dblock
ps. I always thank you for grape.