You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
grape/lib/grape/validations/validators/coerce.rb:21: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
grape/lib/grape/validations/validators/base.rb:16: warning: The called method `initialize' is defined here
Is there any way we can fail CI when we have these warnings? Maybe a Danger plugin?
K0H205
changed the title
Fix Ruby 2.7 keyword deprecations in validators/coerce
Fix Ruby 2.7 keyword deprecation warning in validators/coerce
Nov 17, 2020
Btw, I had tried in spec_helper to override warn, which worked. The problem was that I couldn't have both specs that expect warnings and always fail on unexpected warnings without some nasty hack. I might retry this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix these deprecation warnings