Update README to fix 404 error issue mounting Grape Using Rack::Cascade #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmchan
force-pushed
the
fix-1515-update_doc
branch
from
1762e86
to
711f392
Compare
dblock
requested changes
Jul 13, 2020
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ | |||
| #### Fixes | |||
|
|
|||
| * Your contribution here. | |||
| * [#2089](https://github.com/ruby-grape/grape/pull/2089): Update README to fix 404 error issue mounting grape using rack::cascade - [@jonmchan](https://github.com/jonmchan). | |||
There was a problem hiding this comment.
Rack::Cascade is capitals and quote it as Rack::Cascade
Error and issue is redundant ;) Maybe "Specify order of mounting Grape with Rack::Cascade in README"?
README.md
Outdated
| ``` | ||
|
|
||
| **NOTE:** Order of loading apps using `Rack::Cascade` matters. The grape application must be last if you want to raise custom 404 errors from grape (such as `error!('Not Found',404)`). If the grape application is not last and returns 404 or 405 response, [cascade utilizes that as a signal to try the next app](https://www.rubydoc.info/gems/rack/Rack/Cascade). This may lead to undesirable behavior showing the [wrong 404 page from the wrong app](https://github.com/ruby-grape/grape/issues/1515). |
There was a problem hiding this comment.
We don't use NOTE like this elsewhere, just say Note that the order of loading ....
Capitalize Grape.
jonmchan
force-pushed
the
fix-1515-update_doc
branch
from
711f392
to
17c7190
Compare
…-1515-update_doc
|
Fixed |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1515.