Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more unit tests for coercion #1978

Merged
merged 1 commit into from
Jan 20, 2020
Merged

more unit tests for coercion #1978

merged 1 commit into from
Jan 20, 2020

Conversation

dnesteryuk
Copy link
Member

What do you think about unit tests for such cases? 🙂

@grape-bot
Copy link

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1978](https://github.com/ruby-grape/grape/pull/1978): More unit tests for coercion - [@dnesteryuk](https://github.com/dnesteryuk).

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Jan 20, 2020

I like me tests.

@dblock dblock merged commit 8e0b232 into master Jan 20, 2020
@dnesteryuk dnesteryuk deleted the chore/coercion-tests branch January 20, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants