Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add failing spec for .rescue_from regression #1959

Closed
wants to merge 1 commit into from
Closed

add failing spec for .rescue_from regression #1959

wants to merge 1 commit into from

Conversation

dm1try
Copy link
Member

@dm1try dm1try commented Jan 9, 2020

see #1957

@grape-bot
Copy link

grape-bot commented Jan 9, 2020 •
edited
Loading

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1959](https://github.com/ruby-grape/grape/pull/1959): Add failing spec for .rescue_from regression - [@dm1try](https://github.com/dm1try).

Generated by 🚫 danger

@dm1try dm1try mentioned this pull request Jan 9, 2020
Merged
@dm1try dm1try force-pushed the failing_spec_for_rescue_from_regression branch from 21fa982 to 7d83fcb Compare January 9, 2020 01:12
@dblock
Copy link
Member

dblock commented Jan 9, 2020

I guess I shouldn't be lazy, #1961 :)

@dblock dblock mentioned this pull request Jan 9, 2020
Merged
@dm1try
Copy link
Member Author

dm1try commented Jan 9, 2020

#1961 includes the changes

@dm1try dm1try closed this Jan 9, 2020
@dm1try dm1try deleted the failing_spec_for_rescue_from_regression branch January 9, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dm1try @grape-bot @dblock