Fix error messages for nested multiple params validations #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikolya
force-pushed
the
fix-errors-for-multiple-params-validations
branch
from
170ee14
to
a64401d
Compare
dblock
reviewed
Oct 5, 2019
| @@ -5,11 +5,12 @@ class AttributesIterator | |||
|
|
|||
| attr_reader :scope | |||
|
|
|||
| def initialize(validator, scope, params) | |||
| def initialize(validator, scope, params, multiple_params: false) | |||
There was a problem hiding this comment.
How about writing another attribute iterator, MutlipleParamsAttributeIterator and SingleParamsAttributeIterator instead of this additional parameter? Subclass from an AttributeIterator and we have something much cleaner.
There was a problem hiding this comment.
Great idea, thanks! I changed this part in the last commit, please check it out. Also the build is green now.
dblock
reviewed
Oct 5, 2019
|
This is solid work. See above for my comments. Needs a green build, please. |
Previously all the multiple params validators returned messages
without considering the scope.
For example, in case of hash params:
`{ "param_1,param_2": 'error message' }`
instead of:
`{ "hash[param_1],hash[param_2]": 'error message' }`
Or in case of arrays indexes were ignored completely:
`{ "param_1,param_2": 'error message' }`
instead of:
`{ "array[1][param_1],array[1][param_2]": 'error message' }`
This commit fixes it by using AttributesIterator in a similar way to
Grape::Validations::Base.
TBH, no idea how they managed to pass before
bikolya
force-pushed
the
fix-errors-for-multiple-params-validations
branch
from
a64401d
to
b9c1a32
Compare
|
Perfect, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously multiple params validators returned messages without considering the scope.
For example, in case of hash params:
{ "param_1,param_2": 'error message' }instead of:
{ "hash[param_1],hash[param_2]": 'error message' }Or in case of arrays, indexes were ignored completely:
{ "param_1,param_2": 'error message' }instead of:
{ "array[1][param_1],array[1][param_2]": 'error message' }This PR fixes it by using
AttributesIteratorin a similar way toGrape::Validations::Base.Also the specs are refactored to work in a similar way to the ordinary single-parameter validations.