Add documented but not implemented feature so a user can insert a middleware at a specific point in the stack #1787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability for a user to insert a middleware at a specific point in the middleware stack using the
insert
method.Where should the reviewer start?
First commit demonstrates failing integration test case. Second fixes it. Recommended to step through.
Any background context to be provided?
In the README of this project it is documented that a user can insert a middleware at a specific point in the stack using the
.insert
method.Notable passage:
Notable example:
This was added in c2e41f7 but it appears that the
insert
method was missed from the public API and only exposed on the internal middleware stack class.Any specific implementation details?
I added the CHANGELOG entry under
Fixes
as it is 'fixing' a discrepancy between the documentation and the code but unsure whether it belongs best under this or underFeatures
.