Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rescue from non-StandardError exceptions #1749

Merged

Conversation

dm1try
Copy link
Member

@dm1try dm1try commented Mar 11, 2018

ref #1745 #1713

@dm1try dm1try requested a review from dblock March 11, 2018 16:07
@dm1try dm1try force-pushed the allow_explicitly_rescue_non_standard_errors branch from 7b68383 to f77a998 Compare March 11, 2018 16:15
@dblock dblock merged commit 648b53a into ruby-grape:master Mar 11, 2018
@dblock
Copy link
Member

dblock commented Mar 11, 2018

Perfect. This solves the actual bug of being able to rescue non-StandardError exceptions, so we can now talk about changing the behavior of :all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants