Fix infinite loop when mounting endpoint with same superclass #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a bit of a mind bender to work through, so I definitely welcome other eyes on this...especially if they are familiar with how |
|
Amazing. I think we need specs that call out this issue and scenario rather than making the repro part of the loading performance spec - revert that one and write a more minimal spec that otherwise fails with this particular error? |
|
This is a great catch @jkowens 👍 |
|
@jkowens Will merge if you can address my comment above, please. |
jkowens
changed the title
Subclass APIs were being assigned the same top level inheritable settings from the superclass. When an API attempted to mount another API with the same superclass, the same setting object would be added to the setting stack. When an attempt was made to retrieve a value from the settings, it would sit in loop calling itself.
|
@dblock I've added a spec for this specific scenario as suggested. Thanks for the feedback 👍 |
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent and child classes were pointing to the same inheritable setting creating an infinite loop when retrieving values. Fixes #1683
This was a regression introduced with commit 2c4d574.