rescue_from :all documentation fix
#1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `rescue_from` only rescues `StandardError` exceptions, rescuing `NotImplementedError` will have no effect as it is a `ScriptError` instead of `StandardError`.
Added another spec to demonstrate current behavior when attempting to rescue from a non-StandardError exception. As of now, rescue_from :all only rescues StandardError exceptions, so when a non-StandardError exception is encountered, Grape will not trap the error.
Generated by 🚫 danger |
Jelkster
force-pushed
the
rescue-all-doc-fix
branch
from
da1dc71
to
729be86
Compare
Jelkster
force-pushed
the
rescue-all-doc-fix
branch
from
729be86
to
69e2109
Compare
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
rescue_from :alldocumentation aspect of #1713