Fix wrong transformation of empty Array in declared params #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablonahuelgomez
force-pushed
the
make-declared-transform-to-what-is-expected
branch
2 times, most recently
from
a916b06
to
594f570
Compare
dblock
requested changes
Nov 21, 2017
pablonahuelgomez
force-pushed
the
make-declared-transform-to-what-is-expected
branch
from
594f570
to
1d5fec7
Compare
|
@dblock changes applied. Travis is red due to a worker issue: |
dblock
reviewed
Nov 21, 2017
dblock
reviewed
Nov 21, 2017
Updating PostBeforeFilter module to handle empty given arrays as expected: returning an empty array instead of an empty hash.
pablonahuelgomez
force-pushed
the
make-declared-transform-to-what-is-expected
branch
from
1d5fec7
to
c2c89ce
Compare
pablonahuelgomez
changed the title
declared transform passed params to what is expected
|
Merged |
pablonahuelgomez
deleted the
make-declared-transform-to-what-is-expected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
PostBeforeFiltermodule to handle empty given arrays as expected:returning an empty array instead of an empty hash.
Specs have been taken from #1678 and from this commit.