Silence warnings #1632
Silence warnings #1632
Conversation
|
Better! Lets finish this. If this lets us turn on warnings as errors in the build that should be part of this. If it fully resolves #1582, it needs a CHANGELOG entry. Fix the build, needs Remove things that are unrelated to this PR. Squash. |
|
@dblock how is that? |
initialize vars in initializers subclass hashie mash to silence warnings rubocop fixes add changelog entry Revert "use correct params class in declared" This reverts commit 61f0c8e. fix tests
|
This looks great. Before I merge this, what is the effect of |
|
@dblock that is in conjunction with this pull request in hashie: hashie/hashie#395 They have you subclass |
|
I understand but why do we ever want this? Don't you want to know when you're assigning a parameter that overrides something built in? |
|
@dblock you're right. i have removed that. |
|
I'll wait on 🍏 to re-review. |
Generated by 🚫 danger |
|
Merged, thanks. |
use correct params class in declared add changelog entry add tests for declared class fix rubocop make changelog entry better remove puts in tests one more puts change test names conform changelog entry return dynamic class name parse response instead remove params Instrument validators with ActiveSupport::Notifications Suppress `warning: method redefined` Bugfix: Correctly handle `given` in Array params (ruby-grape#1625) * Bugfix: Correctly handle `given` in Array params Array parameters are handled as a parameter that opens a scope with `type: Array`; `given` opens up a new scope, but was always setting the type to Hash. This patch fixes that, as well as correctly labeling the error messages associated with array fields. * Code review fix * Add CHANGELOG entry Add ability to include an array of modules as helpers Changing helpers DSL to allow the inclusion of many modules. This attemps to bring a better readability, since it seems to be more intuitive to send a list of modules when the message in question is called helpers. ensure we return a string from test return json in tests Update README according to new `helpers` macro interface Silence warnings (ruby-grape#1632) * silence warnings initialize vars in initializers subclass hashie mash to silence warnings rubocop fixes add changelog entry Revert "use correct params class in declared" This reverts commit 61f0c8e. fix tests * remove disable_warnings in hashie mash * make rubocop happy * fix hashie tests
@dblock maybe something like this?
fixes #1582