Make versioner consider the mount destination path #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Feb 4, 2017
lib/grape/endpoint.rb
Outdated
| @@ -295,7 +295,8 @@ def build_stack(helpers) | |||
| stack.use Grape::Middleware::Versioner.using(namespace_inheritable(:version_options)[:using]), | |||
| versions: namespace_inheritable(:version) ? namespace_inheritable(:version).flatten : nil, | |||
| version_options: namespace_inheritable(:version_options), | |||
| prefix: namespace_inheritable(:root_prefix) | |||
| prefix: namespace_inheritable(:root_prefix), | |||
| mount_path: namespace_stackable(:mount_path)[0] | |||
dblock
reviewed
Feb 4, 2017
| @@ -25,6 +25,7 @@ def default_options | |||
|
|
|||
| def before | |||
| path = env[Grape::Http::Headers::PATH_INFO].dup | |||
| path.sub!(mount_path, '') if mount_path && path.start_with?(mount_path) | |||
There was a problem hiding this comment.
This seems dangerous, like foo vs. foobar, one starts with another.
There was a problem hiding this comment.
Indeed, I have just force-pushed changes
|
@dblock Could you confirmed current changes? |
9 similar comments
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636
If my perception is correct, it is enough that only this changes is enough.
@dblock Thoughts?