Avoid failing even if given path does not match with prefix #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namusyaka
force-pushed
the
fix-1546
branch
3 times, most recently
from
0352c44
to
f0711eb
Compare
|
Let's merge this and deal with rubocop separately (open a bug for them @namusyaka?). |
|
@thomas-peyric can you please confirm this fixes your problem? |
|
It's OK, problem solved |
|
I opened an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I partially reverted changes and disabled rubocop in the line. Also, I added a spec for this case.
Rubocop seems to have a bug about NumericPredicate.
@dblock @thomas-peyric Thoughts?