Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates invalid_versioner_option translation. #1536

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Updates invalid_versioner_option translation. #1536

merged 1 commit into from
Dec 19, 2016

Conversation

Lavode
Copy link
Contributor

@Lavode Lavode commented Dec 19, 2016

Adds :accept_version_header as valid setting.

@grape-bot
Copy link

grape-bot commented Dec 19, 2016 •
edited
Loading

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Dec 19, 2016

The danger error above is my fault, fixed in #1538, you can rebase.

@Lavode
Updates invalid_versioner_option translation.
e1825c5 
Adds `:accept_version_header` as valid setting.
@Lavode
Copy link
Contributor Author

Lavode commented Dec 19, 2016

Cheers. Rebased and pushed. :)

@dblock dblock merged commit 0033f1d into ruby-grape:master Dec 19, 2016
@Lavode Lavode deleted the update-invalid-versioner-localization branch December 19, 2016 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lavode @grape-bot @dblock