Skip running param validators inside inactive given blocks (#1433) #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2016 16:18
Demonstrates failures when using given clause for params, especially when they set allow_blank: false
Move should_validate? check to validator base class so it gets called for all validators. This replaces the custom code in allow_blank, and adds it to validators where it didn't previously get called (like coerce).
|
Hat tip to @andrew13nguyen for the UT code that demonstrates multiple type validators for the same parameter. I tweaked it to make the types different just to add another layer of chaos. |
|
This is some excellent work @jlfaber & @andrew13nguyen. Merging. |
|
Thanks @dblock for the merge! Any chance we can get this tagged for release? |
|
We try not to release too often, but I'll queue this up for myself for this/next week. Usually that involves running grape next against a very large API I am looking at over here. |
|
Of course if @namusyaka @dm1try @marshall-lee @adamgotterer want to cut a release before that go for it! |
|
👍 Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address both the primary issue identified in #1433, which was related to the
typecoercer, and related issues withallow_blank. In both cases, these validators were being run even when their scopes indicated they should not (since the associatedgivencriterion had not been met).