Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ruby-2.0 and mustermann19, use mustermann-grape instead #1470

Merged
merged 2 commits into from
Sep 11, 2016

Conversation

namusyaka
Copy link
Contributor

ref #1469

@grape-bot
Copy link

grape-bot commented Jul 28, 2016

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@namusyaka
Copy link
Contributor Author

OMG, latest mustermann requires ruby-2.1 or later.
@dblock What do you think?

@dblock
Copy link
Member

dblock commented Jul 29, 2016

I say we go for it and drop 2.0. Rails already requires 2.2.

@namusyaka namusyaka changed the title Drop mustermann19, use mustermann-grape instead Drop ruby-2.0 and mustermann19, use mustermann-grape instead Jul 29, 2016
@dblock
Copy link
Member

dblock commented Jul 29, 2016

Does Rails 3 not work with Ruby 2.1? If so we should mention it and git rm gemfiles/rails_3.gemfile and remove it from Appraisals.

@dblock
Copy link
Member

dblock commented Jul 29, 2016

I release 0.17.0, maybe make a major version increment (replace 0.17.1 -> 0.18.0) with this PR?

@dblock
Copy link
Member

dblock commented Sep 9, 2016

Bump @namusyaka?

@namusyaka
Copy link
Contributor Author

Sorry for the delay. rails-3.2-stable seems like to support ruby 2.1.

I release 0.17.0, maybe make a major version increment (replace 0.17.1 -> 0.18.0) with this PR?

Yeah, the major version should be incremented, but I'd like to merge a few things for fixing bugs.

@namusyaka
Copy link
Contributor Author

namusyaka commented Sep 9, 2016

Just rebased and force pushed.

@dblock
Copy link
Member

dblock commented Sep 9, 2016

You also need to drop rails 3 from appraisals, no?

@@ -13,11 +13,13 @@
#### Features

* [#1393](https://github.com/ruby-grape/grape/pull/1393): Middleware can be inserted before or after default Grape middleware - [@ridiculous](https://github.com/ridiculous).
* [#1390](https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@rosa](https://github.com/rosa).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind cleaning this up. Looks like some case-sensitive changes creeped in here that shouldn't be part of this commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, sorry. fixed.

@namusyaka
Copy link
Contributor Author

rails-3.2 and ruby-2.1 has passed specs on travis. https://travis-ci.org/ruby-grape/grape/jobs/158980775

@dblock dblock merged commit 0a9461f into master Sep 11, 2016
@dblock
Copy link
Member

dblock commented Sep 11, 2016

Merged, thanks!

namusyaka added a commit that referenced this pull request Sep 11, 2016
namusyaka added a commit to namusyaka/grape that referenced this pull request Sep 11, 2016
namusyaka added a commit that referenced this pull request Sep 12, 2016
@namusyaka namusyaka deleted the use-mustermann-grape branch September 14, 2016 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants