Add Danger #1455
Add Danger #1455
Conversation
|
Well, this is not going to work. https://docs.travis-ci.com/user/pull-requests#Pull-Requests-and-Security-Restrictions Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them. Pull requests sent from forked repositories do not have access to encrypted variables or data. Suggestions? |
|
The guide covers this - http://danger.systems/guides/getting_started.html#setting-up-an-access-token I can amend it if it wasn't obvious?
And later
So long as you haven't given the account any access, the token is effectively valueless for anything but commenting. |
|
I missed the "Display value in build log" part. Restarted the build. |
|
The format for our changelog has a dash before |
|
Cool beans, great, looks good, I've pushed a fix and a CHANGELOG entry. The Danger message should get deleted. |
| @@ -9,6 +9,8 @@ | |||
| * [#1366](https://github.com/ruby-grape/grape/pull/1366): Store `message_key` on `Grape::Exceptions::Validation` - [@mkou](https://github.com/mkou). | |||
| * [#1398](https://github.com/ruby-grape/grape/pull/1398): Added `rescue_from :grape_exceptions` - allow Grape to use the built-in `Grape::Exception` handing and use `rescue :all` behavior for everything else - [@mmclead](https://github.com/mmclead). | |||
| * [#1443](https://github.com/ruby-grape/grape/pull/1443): Extended `given` to receive a `Proc` - [@glaucocustodio](https://github.com/glaucocustodio). | |||
| * [#1455](https://github.com/ruby-grape/grape/pull/1455): Adds some automated PR rules around CHANGELOGs and ensuring the `fit` and `fdescribe` don't end up in the test suite. - [@orta](https://github.com/orta). | |||
There was a problem hiding this comment.
There should be no period after suite.. Also remove some, that's too verbose. I would remove the bit about fit and fdescribe.
|
Lets run |
| @@ -24,6 +24,8 @@ | |||
|
|
|||
| require 'virtus' | |||
|
|
|||
| # I will remove this comment in an amended commit once Danger is set up. | |||
|
👍 |
|
Excellent, merging. |
|
Ok, so, how can we make this shareable across the Grape ecosystem? |
Sorry ~250 watchers, I got hit by isaacs/github#361
Pre-requisite
This requires the CI ENV var
DANGER_GITHUB_API_TOKENto be set up, so someone has to follow this guide from "Creating a GitHub Account for Danger to use".I'd recommend making a new GitHub account for GrapeCI - see our DangerCI one, don't give it access to any of the repos.
Then re-build this PR. I've not made any README changes, so it should show a message about me adding one.