Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-2.2.2 rubies since they no longer work with AS 5 (#1440) #1441

Merged
merged 1 commit into from
Jul 17, 2016
+9 −4
Merged

Remove pre-2.2.2 rubies since they no longer work with AS 5 (#1440) #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@ language: ruby
sudo: false

rvm:
- 2.3.1
- 2.3.0
- 2.2
- 2.1
- 2.0.0
- 2.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to build all those, how about just the latest 2.2 (does just 2.2 work)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think '2.2' will pick up 2.2.0, not 2.2.5 (which is the latest 2.2.x release). How about 2.2.5 and 2.3.1? (omitting 2.2.2, 2.2.3, 2.2.4, and 2.3.0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I would leave 2.3.0 just cause it's recent enough.

- rbx-2
- jruby-19mode
- ruby-head
- jruby-head

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#### Features

* [#1440](https://github.com/ruby-grape/grape/pull/1441): Supports only Ruby 2.2.2 and later - [@jlfaber](https://github.com/jlfaber).
* [#1393](https://github.com/ruby-grape/grape/pull/1393): Middleware can be inserted before or after default Grape middleware - [@ridiculous](https://github.com/ridiculous).
* [#1390](https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@Rosa](https://github.com/Rosa).
* [#1366](https://github.com/ruby-grape/grape/pull/1366): Store `message_key` on `Grape::Exceptions::Validation` - [@mkou](https://github.com/mkou).
Expand Down
6 changes: 6 additions & 0 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Upgrading Grape

### Upgrading to >= 0.16.0

#### Removed official support for Ruby < 2.2.2

Since 0.16.3 Grape is no longer automatically tested against versions of Ruby prior to 2.2.2.
This is because of its dependency on activesupport which, with version 5.0.0, now requires
at least Ruby 2.2.2.

#### Changed priority of `rescue_from` clauses applying

Since 0.16.3 `rescue_from` clauses declared inside namespace would take a priority over ones declared in the root scope.
Expand Down