Avoid polluting Grape::Middleware::Error #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1456,6 +1456,34 @@ def custom_error!(name) | |||
| expect(last_response.body).to eq 'hello bob' | |||
| end | |||
|
|
|||
| it 'avoids polluting global namespace' do | |||
| class A < Grape::API | |||
There was a problem hiding this comment.
These should be let(:A) { Class.new(...) } to avoid polluting (see what I did there :) the global namespace.
There was a problem hiding this comment.
OMG you're right ;) Thanks!
namusyaka
force-pushed
the
avoid-polluting
branch
2 times, most recently
from
361ec06
to
24b68e8
Compare
namusyaka
force-pushed
the
avoid-polluting
branch
from
24b68e8
to
051f465
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1420
/cc @etehtsea @dblock