add back message key in order to have error_codes #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs tests and a CHANGELOG entry, please. |
|
@dblock Done. Thanks for the feedback |
| @@ -9,6 +9,7 @@ class Validation < Grape::Exceptions::Base | |||
| def initialize(args = {}) | |||
| fail 'Params are missing:' unless args.key? :params | |||
| @params = args[:params] | |||
| @message_key = args[:message] if args.key?(:message) && args[:message].is_a?(Symbol) | |||
| args[:message] = translate_message(args[:message]) if args.key? :message | |||
| super | |||
There was a problem hiding this comment.
Can I nitpick? Is this better? Avoids checking key? twice.
return unless args.key?(:message)
@message_key = args[:message] if args[:message].is_a?(Symbol)
args[:message] = translate_message(args[:message])or with an if, I don't care.
There was a problem hiding this comment.
Hmm wouldn't the return bypass the super method?
I like the idea of not checking the key twice though.
There was a problem hiding this comment.
Would you prefer that version ?
super && return unless args.key?(:message)
@message_key = args[:message] if args[:message].is_a?(Symbol)
args[:message] = translate_message(args[:message])
super
or
if args.key?(:message)
@message_key = args[:message] if args[:message].is_a?(Symbol)
args[:message] = translate_message(args[:message])
end
super
(I think I prefer the last one)
There was a problem hiding this comment.
definitely the latter 👍
|
Thanks! 😄 What do you think? |
|
Merged squashed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my situation, in the exception validations, I need message keys as well as the translations in order to pass error codes