-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Grape::API.recognize_path #1339
Conversation
1d791a0
to
209f56f
Compare
@@ -120,6 +120,7 @@ def reset_routes! | |||
end | |||
|
|||
def mount_in(router) | |||
@router ||= router |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't address mounting an endpoint in multiple places, but eventually we will. So maybe we don't want @router
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, right. Removed.
It's on the right track, but shouldn't |
209f56f
to
64e42ae
Compare
@dblock Now |
Very good. I think the last thing we need is a README entry that explains how you can use |
64e42ae
to
3162840
Compare
Hmm, makes sense. If I understand thing correctly, |
3162840
to
454dc0d
Compare
454dc0d
to
1ff934b
Compare
Perfect, merging. |
ref #1072
I've tried to implement
Grape::DSL::InsideRoute#recognize_path
.It returns value conforming the format like
[original pattern, expanded params]
.This is a first step. I'd like to hear your opinions.
Thanks.