Add test for OPTIONS and HEAD requests with catch-all #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This illustrates the issue described in ruby-grape#1056 by adding a options and head request when the catch-all route is enabled.
|
Well, |
|
204 is reasonable for an empty response. But I'm reading that it should return 200 OK. But either way getting this to pass would be an improvement 👍 |
|
Very good, the passing spec is a merge. Lets close the related bug and review whether we want to change the status code here (open new issues as appropriate). |
dblock
added a commit
that referenced
this pull request
Mar 16, 2016
Add test for OPTIONS and HEAD requests with catch-all
|
This possibly needs a CHANGELOG entry since I believe this was a known bug now fixed, @namusyaka please. |
namusyaka
added a commit
to namusyaka/grape
that referenced
this pull request
Mar 16, 2016
przbadu
pushed a commit
to przbadu/grape
that referenced
this pull request
Apr 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1057
I've cherry-picked @ekampp's commit and fixed a little bit.
Thoughts?