Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specs circular dependency #1282

Merged
merged 2 commits into from
Feb 22, 2016
Merged

Fix specs circular dependency #1282

merged 2 commits into from
Feb 22, 2016

Commits on Feb 21, 2016

  1. Fix specs circular dependency 

    The whole test suit is green but specs below are failing:
```
rspec spec/grape/api_spec.rb
rspec spec/grape/entity_spec.rb
rspec spec/grape/middleware/formatter_spec.rb
```

The reason is `require 'active_support/core_ext/hash'` which is defined
in exception_spec.rb. It hides the real problem that Grape does not
require active_support library which provides hash to xml convertation.
    @304
    304 committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    2b579c0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @304
    304 committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    8bdd129 View commit details
    Browse the repository at this point in the history