Add header support for middleware #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val ? @header[key.to_s] = val : @header.delete(key.to_s) | ||
| else | ||
| @header | ||
| module HeaderMethods |
There was a problem hiding this comment.
Should be in a separate file probably. And I don't love the name "HeaderMethods", maybe just "Headers"?
There was a problem hiding this comment.
Agreed. I'll fix it.
namusyaka
force-pushed
the
add-header-support
branch
2 times, most recently
from
120c087
to
f21e75a
Compare
|
Fixed and force pushed. |
| response | ||
| end | ||
|
|
||
| def reflect_headers(response) |
There was a problem hiding this comment.
Should this be private?
Maybe rename it to merge_headers?
|
Sorry more minor comments, please. |
Extract #headers from DSL::InsideRoute to DSL::Headers
namusyaka
force-pushed
the
add-header-support
branch
from
f21e75a
to
967db12
Compare
|
Thanks for polite reviewing! Pushed. |
dblock
added a commit
that referenced
this pull request
Jan 17, 2016
Add header support for middleware
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1069
This adds the
headermethod for activating it in our middleware.Could you review the pull request?