Do not convert Rack::Response to Rack::Response #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch. Can you please add a line to the CHANGELOG? I will probably cut a dot release with this since it's a regression. |
While using https://github.com/aserafin/grape_logging grape middleware after an upgrading grape from 0.11 to 0.12 I've been stuck with an issue: ``` NoMethodError (undefined method `downcase' for 2:Fixnum) ``` That's because `Middleware#response` tries to convert `Rack::Response` to `Rack::Response` and fails.
dmitry
force-pushed
the
fix/do-not-convert-rack-response
branch
from
4e0fc3a
to
7ad647a
Compare
|
@dblock Rebased with |
dblock
added a commit
that referenced
this pull request
Jun 25, 2015
Do not convert Rack::Response to Rack::Response
|
Merged. |
|
Just ran into this problem. Will really appreciate a new release! Thanks! |
|
I was just having the same problem, and I wonder if this PR fully fixes it. After building the gem from the latest source, I still had the problem, but it goes away when using 0.11.0. |
|
+1. Still seeing this exact error message after building a 0.12.1 version from master. |
|
What about using |
|
@dmitry That ought to be the same code in master, right? In any case, the problem is still there. |
|
@AndyDangerous can you show the full stacktrace? |
|
Here it is, @dmitry |
|
Got the same error today on one of my project using Grape 0.12.0 ! |
|
@patfrat you have to use grape from master, because this patch isn't released in a new gem yet. |
|
Grape 0.10.0 is working for me ... not 0.11.0 nor 0.12.0 |
|
@dmitry i use grape from master in my project |
|
It's another issue, and the issue is in rails 4.2.3: https://github.com/rails/rails/blob/4-2-stable/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb#L654 |
|
Is it happens while tests or in a development/production mode? |
|
For us, it was in development. |
|
@AndyDangerous @patfrat I believe you have to move grape middleware upper than Basically you are experiencing an issue inside |
|
In development mode too |
|
How do you mounting grape API? |
|
I am using Rack::Cascade.new [Api, ApiDoc, statics] |
|
@patfrat but where do you put this Rack::Cascade instance? |
|
I believe we have to stop chatting here about your issues, and you have to create a new issue... because it's unrelated to this this fix at all. |
|
ok @dmitry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using https://github.com/aserafin/grape_logging grape middleware after an upgrading grape from 0.11 to 0.12 I've been stuck with an issue (aserafin/grape_logging#6):
That's because
Middleware#responsetries to convertRack::ResponsetoRack::Responseand fails.