Custom validations issue in Grape 2.3.0

[schinery]

I've just tried upgrading from Grape 2.2.0 to 2.3.0 and the custom validations I have defined in my project are no longer "working", as in I now get a 'Grape::Validations.require_validator': unknown validator: greater_than_or_equal_to (Grape::Exceptions::UnknownValidator) error when starting a Rails console or server.

The validations currently look like this:

class GreaterThanOrEqualToValidator < Grape::Validations::Validators::Base
  def validate_param!(attr_name, params)
    return unless params.key?(attr_name) && params.key?(@option)
    return if params[attr_name] >= params[@option]

    raise Grape::Exceptions::Validation.new params: [@scope.full_name(attr_name)],
                                            message: "must be greater than or equal to #{@option}"
  end
end

And the validations are defined in a app/validations folder with the API mounted at app/api.

I saw that #2516 had been added as part of the 2.3.0 release, and was wondering if I am missing something that is now needed because of that change which isn't currently in the README?

Project env:

• Grape 2.3.0
• Rails 8.0.1
• Ruby 3.4.1

[dblock]

@ericproulx

[ericproulx]

@schinery did you require it before ? and what's the name of your file ?

[ericproulx]

I can reproduce the issue but only if the validators were not required before.

[schinery]

@ericproulx

and what's the name of your file?

For the example above the file is named app/validators/greater_than_or_equal_to_validator.rb.

did you require it before?

Previously no, it "just worked", but requiring the custom validations now does seem to have resolved my issue.

[schinery]

As I have a few custom validations, I've resolved this by putting the following in my base API file (app/api/application_api.rb).

# Require custom validations so that they are available in Grape
Dir["#{File.dirname(__FILE__)}/../validators/*.rb"].each { |file| require file }

class ApplicationAPI < Grape::API
  # Other code
end

Thanks for the quick replies @dblock @ericproulx, I'm happy to close this (non) issue

[dblock]

Previously no, it "just worked", but requiring the custom validations now does seem to have resolved my issue.

This is still a behavior change, @schinery would you please care to add a short paragraph to UPGRADING.md?

[schinery]

This is still a behavior change, @schinery would you please care to add a short paragraph to UPGRADING.md?

I can do. Still validating some other stuff centered around the upgrade, once I get them ironed out, I'll throw something together

[schinery]

This is still a behavior change, @schinery would you please care to add a short paragraph to UPGRADING.md?

@dblock #2534