Skip to content

Array[File] doesn't validate correctly. #1986

Closed
#2031
Closed
Array[File] doesn't validate correctly.#1986
#2031
Assignees
dnesteryuk
Labels
bug?

Description

@jpickwell
jpickwell
opened on Feb 4, 2020

If you have a parameter of type Array[File], validation always fails because the primitive type coercer is trying to do @coercer[val], and @coercer is ::File.

optional(:nested, type: Hash, default: {}) do
  optional :files, type: Array[File]
end

Version 1.2.5 doesn't have this issue, so 1.3.0 broke parameter type coercion.

Activity

  1. dblock
    added
    bug?
    on Feb 4, 2020

  2. dblock commented on Feb 4, 2020

    @dblock
    dblock
    on Feb 4, 2020
    Member

    Appreciate a spec + fix in a PR. Thanks.

  3. dnesteryuk
    added a commit that references this issue on Mar 29, 2020

    special types provided by Grape are custom ones

    d57740f
  4. dnesteryuk
    self-assigned this
    on Mar 29, 2020
  5. dnesteryuk
    added 2 commits that reference this issue on Mar 29, 2020

    special types provided by Grape are custom ones

    2e58a1a

    special types provided by Grape are custom ones

    f3073e6
  6. dblock
    closed this as completedin #2031on Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug?

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions