-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activesupport 5.0.0 breaks CI tests #1440
Comments
Using ~> 4.2 didn't work since rails actually uses older versions of activesupport. Trying again with < 5.0.0. |
That seems to have fixed it. I'll force-push a revision to add a CHANGELOG line and correct the commit message, then I think PR #1441 will be good to go. (Assuming everyone is ok with holding off on taking activesupport 5.0.0 for now.) |
Just bringing my comment from #1441, lets not restrict grape to AS 4.x, but fix the build by removing incompatible rubies. |
Added explicit checking of 2.2.2, 2.2.3, 2.2.4, 2.2.5, and 2.3.1 fixes ruby-grape#1440
Updated #1441 to remove pre-2.2.2 rubies and add explicit checks for 2.2.2 - 2.3.1 |
Seeing these errors on ruby versions below 2.2.2:
Looks like grape was picking up 4.2.6 prior to June 30 when 5.0.0 came out.
There's no version currently listed for activesupport in grape.gemspec. Perhaps it should be changed to this?
s.add_runtime_dependency 'activesupport', '~> 4.2'
The text was updated successfully, but these errors were encountered: