Pull request #136 breaks JSON encoded parameters with Server 500 error

[jonhyman]

The latest commit to bring in pull request #136 broke JSON encoded parameters for me.

I couldn't get a good spec working on this, yet when I mounted with Rack and ran a server, I could reproduce. Here's how to reproduce:

1. Create config.ru

require 'multi_json'
require 'grape'

class Foo < Grape::API
  post do
    params[:cities].map do |c|
      c[:city][:name]
    end.join(' ')
  end
end

run Rack::URLMap.new "/" => Foo

1. Run the server with rackup -p 3000
2. Open up irb and type

require 'multi_json'
require 'rest-client'
city1 = {:city => {:name => "Dallas"}}
city2 = {:city => {:name => "Austin"}}
parameters = MultiJson.encode({:cities => [city1, city2]})
RestClient.post('http://localhost:3000', parameters)

On master, this will throw a Server 500 error.

If you change lib/grape/middleware/formatter.rb line 18 from

env.dup.inject({}){|h,(k,v)| h[k.downcase[5..-1]] = v if k.downcase.start_with?('http_'); h}

back to

env.dup.inject({}){|h,(k,v)| h[k.downcase] = v; h}

then rerunning will produce the proper output of "Dallas Austin"

[meh]

What does RestClient send as Accept?

Because the previous behavior was broken, the only reason for it being broken now is that RestClient is passing an Accept that isn't application/json.

[jonhyman]

Even sending application/json doesn't work.

RestClient.post('http://localhost:3000', parameters, :content_type => :json)

Here's the Rack request this produces. Ignore all the extra slashes.

"#<Rack::Request:0x007fe21a552d38 @env={\"CONTENT_LENGTH\"=>\"66\", \"CONTENT_TYPE\"=>\"application/json\", \"GATEWAY_INTERFACE\"=>\"CGI/1.1\", \"PATH_INFO\"=>\"/\", \"QUERY_STRING\"=>\"\", \"REMOTE_ADDR\"=>\"127.0.0.1\", \"REMOTE_HOST\"=>\"localhost\", \"REQUEST_METHOD\"=>\"POST\", \"REQUEST_URI\"=>\"http://localhost:3000/\\", \"SCRIPT_NAME\"=>\"\", \"SERVER_NAME\"=>\"localhost\", \"SERVER_PORT\"=>\"3000\", \"SERVER_PROTOCOL\"=>\"HTTP/1.1\", \"SERVER_SOFTWARE\"=>\"WEBrick/1.3.1 (Ruby/1.9.3/2011-10-30)\", \"HTTP_ACCEPT\"=>\"/; q=0.5, application/xml\", \"HTTP_ACCEPT_ENCODING\"=>\"gzip, deflate\", \"HTTP_USER_AGENT\"=>\"Ruby\", \"HTTP_HOST\"=>\"localhost:3000\", \"rack.version\"=>[1, 1], \"rack.input\"=>#<Rack::Lint::InputWrapper:0x007fe21983d0f8 @input=#StringIO:0x007fe219833cd8>, \"rack.errors\"=>#<Rack::Lint::ErrorWrapper:0x007fe21983cd60 @error=#<IO:>>, \"rack.multithread\"=>true, \"rack.multiprocess\"=>false, \"rack.run_once\"=>false, \"rack.url_scheme\"=>\"http\", \"HTTP_VERSION\"=>\"HTTP/1.1\", \"REQUEST_PATH\"=>\"/\", \"rack.routing_args\"=>{}, \"api.format\"=>:xml}>\

[meh]

"HTTP_ACCEPT\\"=>\\"/; q=0.5, application/xml\\"

It's not sending the right Accept header.

(I wrote Content-Type before changing the first comment, I forgot it was actually Accept, sorry about that)

[jonhyman]

Yep. That does it. I'll go ahead and close this out. Thanks.