Skip to content

Commit

Permalink
Merge pull request #2248 from dblock/rspec-3.11.0
Browse files Browse the repository at this point in the history
Upgraded to rspec 3.11.0.
  • Loading branch information
dblock committed Feb 27, 2022
2 parents 71cf33a + 76fa2ff commit f48cde3
Show file tree
Hide file tree
Showing 15 changed files with 20 additions and 19 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* [#2233](https://github.com/ruby-grape/grape/pull/2233): A setting for disabling documentation to internal APIs - [@dnesteryuk](https://github.com/dnesteryuk).
* [#2235](https://github.com/ruby-grape/grape/pull/2235): Add Ruby 3.1 to CI - [@petergoldstein](https://github.com/petergoldstein).
* [#2248](https://github.com/ruby-grape/grape/pull/2248): Upgraded to rspec 3.11.0 - [@dblock](https://github.com/dblock).
* Your contribution here.

#### Fixes
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/multi_json.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/multi_xml.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack2_2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack_edge.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_5.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_6.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_6_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_7.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_edge.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ group :test do
gem 'mime-types'
gem 'rack-jsonp', require: 'rack/jsonp'
gem 'rack-test', '~> 1.1.0'
gem 'rspec', '~> 3.9.0'
gem 'rspec', '~> 3.11.0'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'test-prof', require: false
end
Expand Down
12 changes: 6 additions & 6 deletions spec/grape/dsl/request_response_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -160,34 +160,34 @@ def self.imbue(key, value)

describe 'list of exceptions is passed' do
it 'sets hash of exceptions as rescue handlers' do
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => nil)
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => nil })
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
subject.rescue_from StandardError
end

it 'rescues only base handlers if rescue_subclasses: false option is passed' do
expect(subject).to receive(:namespace_reverse_stackable).with(:base_only_rescue_handlers, StandardError => nil)
expect(subject).to receive(:namespace_stackable).with(:rescue_options, rescue_subclasses: false)
expect(subject).to receive(:namespace_reverse_stackable).with(:base_only_rescue_handlers, { StandardError => nil })
expect(subject).to receive(:namespace_stackable).with(:rescue_options, { rescue_subclasses: false })
subject.rescue_from StandardError, rescue_subclasses: false
end

it 'sets given proc as rescue handler for each key in hash' do
rescue_handler_proc = proc {}
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => rescue_handler_proc)
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => rescue_handler_proc })
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
subject.rescue_from StandardError, rescue_handler_proc
end

it 'sets given block as rescue handler for each key in hash' do
rescue_handler_proc = proc {}
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => rescue_handler_proc)
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => rescue_handler_proc })
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
subject.rescue_from StandardError, &rescue_handler_proc
end

it 'sets a rescue handler declared through :with option for each key in hash' do
with_block = -> { 'hello' }
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, StandardError => an_instance_of(Proc))
expect(subject).to receive(:namespace_reverse_stackable).with(:rescue_handlers, { StandardError => an_instance_of(Proc) })
expect(subject).to receive(:namespace_stackable).with(:rescue_options, {})
subject.rescue_from StandardError, with: with_block
end
Expand Down
2 changes: 1 addition & 1 deletion spec/grape/dsl/routing_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Dummy
it 'sets a version for route' do
version = 'v1'
expect(subject).to receive(:namespace_inheritable).with(:version, [version])
expect(subject).to receive(:namespace_inheritable).with(:version_options, using: :path)
expect(subject).to receive(:namespace_inheritable).with(:version_options, { using: :path })
expect(subject.version(version)).to eq(version)
end
end
Expand Down

0 comments on commit f48cde3

Please sign in to comment.