Skip to content

Fix documentation of false/nil default parameter values #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

magni-
Copy link
Contributor

@magni- magni- commented Oct 15, 2021

The default option currently gets dropped, since neither false nor nil are considered "present".

@magni-
Copy link
Contributor Author

magni- commented Oct 15, 2021

I guess "first-time contributor" is repo-specific rather than org-wide :) @LeFnord could you approve the workflow please? Thanks! 🙇🏼

@LeFnord
Copy link
Member

LeFnord commented Oct 16, 2021

ok thank you @magni-

@LeFnord LeFnord merged commit 86b367b into ruby-grape:master Oct 16, 2021
@magni- magni- deleted the pp/boolean-default branch October 16, 2021 08:44
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
…pe#839)

* Fix documentation of false/nil default values

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants