Allow Security Definitions Objects to be defined #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some specs for this feature? Thanks. |
|
@Bugagazavr Yep; I didn't purely because the existing |
| @@ -278,6 +278,8 @@ add_swagger_documentation \ | |||
| This value is added to the `authorizations` key in the JSON documentation. | |||
|
|
|||
|
|
|||
| #### *security_definitions*: | |||
| This value is added to the `securityDefinitions` key in the JSON documentation. | |||
|
|
|||
There was a problem hiding this comment.
maybe adding the spec #security-definitions-object link,
so that the people have an idea
|
@bendodd … thanks, please add specs to have some usage examples and update the changelog, |
bendodd
changed the title
|
@LeFnord Added. Let me know what you think? |
|
@bendodd … loos ok to me :) … please run |
|
Damn it @LeFnord - that is school boy! Apologies; Fixed... |
|
👍 … thanks 😄 |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* Add securityDefinitions to allow Swagger UI to authenticate * Add usage docs and tests for security_definitions * Fix Rubocop errors #badben
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add securityDefinitions to allow Swagger UI to authenticate
A basic solution for #432