Support multiple headers at the same time #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger supports multiple headers but requires that each one uses a unique name. The existing approach overwrote the previous header definition. This also caused issues when changing the value of `#input_apiKey` as it stores the api key with the same name as all defined headers, leading to complete header loss on api key addition. This fix ensures each header is given a unique name. For more information see: https://github.com/swagger-api/swagger-ui#header-parameters
|
This makes total sense. Needs a CHANGELOG entry please. |
|
CHANGELOG entry added, good to merge? |
|
Squash-merged via d6ed844. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger supports multiple headers but requires that each one uses a unique name. The existing approach overwrote the previous header definition. This also caused issues when changing the value of
#input_apiKeyas it stores the api key with the same name as all defined headers, leading to complete header loss on api key addition. This fix ensures each header is given a unique name.For more information see: https://github.com/swagger-api/swagger-ui#header-parameters