Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue where a boolean example value of false would not display in swagger file #46

Merged

Conversation

drewnichols
Copy link
Contributor

Fix for issue #45

@kzaitsev
Copy link
Collaborator

Hello, thank you, can you please rebase your branch? I fixed specs in the master branch.

@drewnichols drewnichols force-pushed the fix-boolean-example-value-of-false branch from 774d5f1 to c54d5c4 Compare May 30, 2020 00:15
@grape-bot
Copy link

grape-bot commented May 30, 2020

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
[#46](https://github.com/ruby-grape/grape-swagger-entity/pull/46): Fixed issue where a boolean example value of false would not display in swagger file - [@drewnichols](https://github.com/drewnichols).

Generated by 🚫 danger

@drewnichols drewnichols force-pushed the fix-boolean-example-value-of-false branch from c54d5c4 to b1a2f02 Compare May 30, 2020 00:17
@drewnichols drewnichols force-pushed the fix-boolean-example-value-of-false branch from b1a2f02 to f55eac0 Compare May 30, 2020 00:20
@drewnichols
Copy link
Contributor Author

@Bugagazavr rebased, flattened and updated the CHANGELOG.md

@kzaitsev kzaitsev merged commit 7bdc730 into ruby-grape:master May 30, 2020
@kzaitsev
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants