Allow to support newest grape entity #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzaitsev
force-pushed
the
new-grape-entity-support
branch
from
a15b000
to
0cf7b71
Compare
kzaitsev
commented
Nov 21, 2016
| @@ -10,7 +10,7 @@ Gem::Specification.new do |s| | |||
| s.email = ['kirik910@gmail.com'] | |||
|
|
|||
| s.summary = 'Grape swagger adapter to support grape-entity object parsing' | |||
| s.homepage = 'https://github.com/Bugagazavr/grape-swagger-entity' | |||
| s.homepage = 'https://github.com/ruby-grape/grape-swagger-entity' | |||
There was a problem hiding this comment.
I think i can do this in separated PR, if this is a problem
|
@dblock Looks like danger requires some updates |
dblock
reviewed
Nov 21, 2016
| @@ -9,6 +9,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * [#8](https://github.com/ruby-grape/grape-swagger-entity/pull/8): Generate enum property if values key is passed in documentation - [@lordnibbler](https://github.com/lordnibbler). | |||
| * [#15](https://github.com/ruby-grape/grape-swagger-entity/pull/15): Allow to support grape entity 0.6.x and later - [@Bugagazavr](https://github.com/Bugagazavr). | |||
There was a problem hiding this comment.
Should just say "Support ...", "Allow" is unnecessary.
|
Would you mind fixing the danger stuff too? It should be: gem 'ruby-grape-danger', '~> 0.1.0', require: falseAnd Dangerfile should just have danger.import_dangerfile(gem: 'ruby-grape-danger') |
kzaitsev
force-pushed
the
new-grape-entity-support
branch
2 times, most recently
from
8c9d73b
to
35d90ba
Compare
kzaitsev
force-pushed
the
new-grape-entity-support
branch
from
35d90ba
to
3d0789a
Compare
|
Ok i update |
|
This is perfect. Want to make a release? |
|
Yep |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.