Use Grape formatter syntax instead of monkey-patching. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2012
|
|
||
| ```ruby | ||
| get "/user/:id", :rabl => "user.rabl" do | ||
| @user = User.fond(params[:id]) |
|
@dblock thanks! |
LTe
added a commit
that referenced
this pull request
Dec 20, 2012
Use Grape formatter syntax instead of monkey-patching.
|
isn't strange to assume the default formmater is the JSON formatter? instead of the user defined formatter? |
|
@guilherme I am not sure I understand the question, could you please elaborate? Thx. |
|
i've misunderstand this: formatter :json, Grape::Formatter::Rablit means that the formatter for JSON is Grape::Formatter::Rabl, if its not possible to use it it will fallback to the default. I was thinking about it would be possible to do something: formatter :xml, Grape::Formatter::RablIn this case the fallback would be the xml default formatter, but it doesnt make any sense. sorry for taking your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work with the next release of Grape. We have refactored formatters in order to enable complete control of output by external libraries without having to monkey-patch Grape. This is hopefully a bit cleaner.
The updated syntax is now as follows:
The formatter implementation will fallback to Grape's JSON formatter.
See ruby-grape/grape#44 as well.