Pass the right options when determining whether to expose an attribute using a block #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e using a block Fixes ruby-grape#378
magni-
force-pushed
the
pp/378-expose-nil-options
branch
2 times, most recently
from
0b1360f
to
9f672c6
Compare
LeFnord
approved these changes
Dec 13, 2023
magni-
force-pushed
the
pp/378-expose-nil-options
branch
from
9f672c6
to
e5a63a1
Compare
magni-
force-pushed
the
pp/378-expose-nil-options
branch
from
e5a63a1
to
be5253f
Compare
LeFnord
reviewed
Dec 13, 2023
|
yeap … will do one today, ok? |
that'd be great, thanks! |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @zverok deduced when opening the issue, the wrong options are getting used when pairing
expose_nil: falsewith a block.Fixes #378