Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill multi_json Dependencies #209

Closed
wants to merge 1 commit into from
Closed

kill multi_json Dependencies #209

wants to merge 1 commit into from

Conversation

u2
Copy link
Contributor

@u2 u2 commented Feb 12, 2016

http://www.mikeperham.com/2016/02/09/kill-your-dependencies/

Some software engineering rules:

No code runs faster than no code.
No code has fewer bugs than no code.
No code uses less memory than no code.
No code is easier to understand than no code.
Kill those dependencies. Your gems and apps will be better for it.

@rngtng
Copy link
Contributor

rngtng commented Feb 12, 2016

epic thx 👍 ;)

@dblock
Copy link
Member

dblock commented Feb 12, 2016

Same questions and issues around merging this as in ruby-grape/grape#1274. Lets have a discussion there first?

@LeFnord
Copy link
Member

LeFnord commented Nov 15, 2016

@u2 … please can you rebase it

@dblock
Copy link
Member

dblock commented Nov 15, 2016

This is a non trivial change even though it looks trivial, it will impact a bunch of people in production who use gems like oj (significantly degraded performance), silently, so there be dragons!

@LeFnord
Copy link
Member

LeFnord commented Nov 16, 2016

saw the referenced discussion … though there was a decision
and it seems, that @u2 removed its fork -> so should it be closed?

@dblock
Copy link
Member

dblock commented Nov 16, 2016

I stand by everything I said in the Grape issue: I'd love this, but with a way to reinstate backward compatibility for existing users. A change that just drops multi_json in favor of JSON prevents that.

@LeFnord
Copy link
Member

LeFnord commented Nov 16, 2016

though this ruby-grape/grape#1274 (comment) was the decision, but yeah, it seems, nothings was done in this direction, so both PRs should be closed

@LeFnord LeFnord closed this Nov 16, 2016
@dblock
Copy link
Member

dblock commented May 2, 2017

Related, ruby-grape/grape#1623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants