Skip to content

Treat RSTRING_END return value as a char* instead of string #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Treat RSTRING_END return value as a char* instead of string #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ec2d26
Upgrade to ruby_header_parser 0.4.2
sue445 Mar 6, 2025
ca7a192
`rake ruby_h_to_go` with Ruby 3.4.2
sue445 Mar 6, 2025
981ca57
Remove temporary header file before running
sue445 Mar 6, 2025
19ac7d6
`rake ruby_h_to_go` with Ruby 3.3.7
sue445 Mar 6, 2025
d87b8ab
Fix test
sue445 Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ group :development do
gem "rake"
gem "rubocop", require: false
gem "rubocop_auto_corrector", require: false
gem "ruby_header_parser", ">= 0.4.1"
gem "ruby_header_parser", ">= 0.4.2"
gem "yard"
end

Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ GEM
rubocop_auto_corrector (0.5.0)
rubocop (>= 1.30.0)
ruby-progressbar (1.13.0)
ruby_header_parser (0.4.1)
ruby_header_parser (0.4.2)
securerandom (0.4.1)
serverspec (2.42.3)
multi_json
Expand Down Expand Up @@ -173,7 +173,7 @@ DEPENDENCIES
rspec-temp_dir
rubocop
rubocop_auto_corrector
ruby_header_parser (>= 0.4.1)
ruby_header_parser (>= 0.4.2)
serverspec
steep
test-unit
Expand Down
2 changes: 2 additions & 0 deletions _tools/ruby_h_to_go/exe/ruby_h_to_go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,6 @@ include_paths ||= DEFAULT_INCLUDE_PATHS
dist_dir ||= DEFAULT_DIST_DIR
dist_preprocessed_header_file ||= DEFAULT_DIST_PREPROCESSED_HEADER_FILE

FileUtils.rm_f(dist_preprocessed_header_file)

RubyHToGo::Cli.new(header_file:, include_paths:, dist_dir:, dist_preprocessed_header_file:).perform
6 changes: 3 additions & 3 deletions _tools/ruby_h_to_go/spec/ruby_h_to_go/function_definition_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
RubyHeaderParser::FunctionDefinition.new(
name: "RSTRING_END",
definition: "RSTRING_END(VALUE str)",
typeref: typeref(type: "char", pointer: :ref),
typeref: typeref(type: "char", pointer: :raw),
args: [
argument(type: "VALUE", name: "str"),
],
Expand All @@ -318,8 +318,8 @@
// Original definition is following
//
// RSTRING_END(VALUE str)
func RSTRING_END(str VALUE) string {
return char2String(C.RSTRING_END(C.VALUE(str)))
func RSTRING_END(str VALUE) *Char {
return (*Char)(C.RSTRING_END(C.VALUE(str)))
}

GO
Expand Down
4 changes: 2 additions & 2 deletions ruby/function_ruby_3_3_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions ruby/function_ruby_3_4_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading