Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions _gem/lib/go_gem/mkmf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ def $objs.empty?; false; end

create_makefile(target, srcprefix)

case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
when /Free Software Foundation/
ldflags = "-Wl,--unresolved-symbols=ignore-all"
when /clang/
ldflags = "-undefined dynamic_lookup"
end

ldflags = GoGem::Util.generate_ldflags
current_dir = File.expand_path(".")

goflags = "-tags=#{GoGem::Util.ruby_minor_version_build_tag}"
Expand Down
50 changes: 4 additions & 46 deletions _gem/lib/go_gem/rake_task.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module GoGem
# end
# end
# end
class RakeTask < ::Rake::TaskLib # rubocop:disable Metrics/ClassLength
class RakeTask < ::Rake::TaskLib
DEFAULT_TASK_NAMESPACE = :go

DEFAULT_GO_BIN_PATH = "go"
Expand Down Expand Up @@ -99,61 +99,19 @@ def initialize(gem_name)
#
# @return [Hash<String, String>]
def self.build_env_vars
ldflags = generate_ldflags
cflags = generate_cflags

# FIXME: Workaround for Ubuntu (GitHub Actions)
if RUBY_PLATFORM =~ /linux/i
cflags.gsub!("-Wno-self-assign", "")
cflags.gsub!("-Wno-parentheses-equality", "")
cflags.gsub!("-Wno-constant-logical-operand", "")
cflags.gsub!("-Wsuggest-attribute=format", "")
cflags.gsub!("-Wold-style-definition", "")
cflags.gsub!("-Wsuggest-attribute=noreturn", "")
ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "")
end
ldflags = GoGem::Util.generate_ldflags
cflags = GoGem::Util.generate_cflags

ld_library_path = RbConfig::CONFIG["libdir"].to_s

{
"GOFLAGS" => generate_goflags,
"GOFLAGS" => GoGem::Util.generate_goflags,
"CGO_CFLAGS" => cflags,
"CGO_LDFLAGS" => ldflags,
"LD_LIBRARY_PATH" => ld_library_path,
}
end

# @return [String]
def self.generate_goflags
"-tags=#{GoGem::Util.ruby_minor_version_build_tag}"
end
private_class_method :generate_goflags

# @return [String]
def self.generate_ldflags
ldflags = "-L#{RbConfig::CONFIG["libdir"]} -l#{RbConfig::CONFIG["RUBY_SO_NAME"]}"

case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
when /Free Software Foundation/
ldflags << " -Wl,--unresolved-symbols=ignore-all"
when /clang/
ldflags << " -undefined dynamic_lookup"
end

ldflags
end
private_class_method :generate_ldflags

# @return [String]
def self.generate_cflags
[
RbConfig::CONFIG["CFLAGS"],
"-I#{RbConfig::CONFIG["rubyarchhdrdir"]}",
"-I#{RbConfig::CONFIG["rubyhdrdir"]}",
].join(" ")
end
private_class_method :generate_cflags

# @yield
def within_target_dir
Dir.chdir(target_dir) do # rubocop:disable Style/ExplicitBlockArgument
Expand Down
47 changes: 47 additions & 0 deletions _gem/lib/go_gem/util.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,52 @@ module Util
def self.ruby_minor_version_build_tag(ruby_version = RUBY_VERSION)
"ruby_#{ruby_version.to_f.to_s.gsub(".", "_")}"
end

# @return [String]
def self.generate_ldflags
ldflags = "-L#{RbConfig::CONFIG["libdir"]} -l#{RbConfig::CONFIG["RUBY_SO_NAME"]}"

case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
when /Free Software Foundation/
ldflags << " -Wl,--unresolved-symbols=ignore-all"
when /clang/
ldflags << " -undefined dynamic_lookup"
end

# FIXME: Workaround for Ubuntu (GitHub Actions)
ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "") if RUBY_PLATFORM =~ /linux/i

ldflags.strip
end

# @return [String]
def self.generate_cflags
cflags =
[
RbConfig::CONFIG["CFLAGS"],
"-I#{RbConfig::CONFIG["rubyarchhdrdir"]}",
"-I#{RbConfig::CONFIG["rubyhdrdir"]}",
].join(" ")

# FIXME: Workaround for Ubuntu (GitHub Actions)
if RUBY_PLATFORM =~ /linux/i
cflags.gsub!("-Wno-self-assign", "")
cflags.gsub!("-Wno-parentheses-equality", "")
cflags.gsub!("-Wno-constant-logical-operand", "")
cflags.gsub!("-Wsuggest-attribute=format", "")
cflags.gsub!("-Wold-style-definition", "")
cflags.gsub!("-Wsuggest-attribute=noreturn", "")
end

# FIXME: Workaround for Alpine
cflags.gsub!("-Wpointer-arith", "") if RUBY_PLATFORM =~ /linux-musl/i

cflags.strip
end

# @return [String]
def self.generate_goflags
"-tags=#{ruby_minor_version_build_tag}"
end
end
end
6 changes: 0 additions & 6 deletions _gem/sig/go_gem/rake_task.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ module GoGem

def self.build_env_vars: () -> { "GOFLAGS" => String, "CGO_CFLAGS" => String, "CGO_LDFLAGS" => String, "LD_LIBRARY_PATH" => String }

def self.generate_goflags: () -> String

def self.generate_ldflags: () -> String

def self.generate_cflags: () -> String

private

def define_go_test_task: () -> void
Expand Down
6 changes: 6 additions & 0 deletions _gem/sig/go_gem/util.rbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
module GoGem
module Util
def self.ruby_minor_version_build_tag: (?String ruby_version) -> String

def self.generate_ldflags: () -> String

def self.generate_cflags: () -> String

def self.generate_goflags: () -> String
end
end
Loading