Skip to content

WIP: Fix format before save #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017
Merged

WIP: Fix format before save #11

merged 1 commit into from
Aug 7, 2017

Conversation

splattael
Copy link
Member

@splattael splattael commented Aug 3, 2017

Fixes #10

@splattael
Copy link
Member Author

@lucerion Thanks for fixing issue #10! ✨

I'll try to test your patch during this weekend 😃

@lucerion
Copy link
Member

lucerion commented Aug 3, 2017

@splattael I have the same plan for this weekend too :)

@lucerion lucerion force-pushed the fix-format-before-save branch 2 times, most recently from edafd6c to c61b60e Compare August 7, 2017 12:30
@lucerion lucerion force-pushed the fix-format-before-save branch from c61b60e to 60241f8 Compare August 7, 2017 13:26
@lucerion
Copy link
Member

lucerion commented Aug 7, 2017

@splattael @tackeyy I've tested it and #10 was fixed +

  • fix partial formatting
def index
  @q = User.search(params[:q])
  @users = @q.result(distinct: true)
end

Select line inside index and try to format it with :Rufo command (with rufo config from #10)

  • close error buffer before formatting

@splattael
Copy link
Member Author

👍 Looks good to me too!!

@lucerion lucerion merged commit 0952beb into master Aug 7, 2017
@lucerion lucerion deleted the fix-format-before-save branch August 7, 2017 14:53
@lucerion
Copy link
Member

lucerion commented Aug 7, 2017

Merged. @splattael thank you!

@lucerion lucerion removed their assignment Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants