-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the pruning of thread pools a public API #761
Conversation
Thanks for the PR! I'll have a careful look. I'll also need to look into the java part, I'd like the behavior to match. |
Ping ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
This makes the pruning of thread pools a public API, which may or may not be a no-op, depending on the underlying thread pool implementation. It also reworks the Ruby implementation to be more aggressive in the pruning - it will kill all to-be-pruned threads in one call instead of doing them one by one. Moreover, workers do not get woken up to check for their idleness anymore, the thread of the caller does it instead.
@pitr-ch updated. Sorry for taking so long. |
@doudou thank you. And no worries, I appreciate you've found time to contribute. |
Gents ... any chance this could be included ? |
We'll see if we can merge this. |
This makes the pruning of thread pools a public API, which may
or may not be a no-op, depending on the underlying thread pool
implementation.
It also reworks the Ruby implementation to be more aggressive in
the pruning - it will kill all to-be-pruned threads in one call
instead of doing them one by one. Moreover, workers do not get
woken up to check for their idleness anymore, the thread of the
caller does it instead.
Closes #652